bdraco
August 22, 2021, 3:03am
21
bdraco
August 22, 2021, 3:14am
22
I think want makes the most sense is to implement the following as entity services:
IncreaseBrightness
→ bond.increase_brightness
DecreaseBrightness
→ bond.decrease_brightness
IncreaseUpLightBrightness
→ bond.increase_up_light_brightness
DecreaseUpLightBrightness
→ bond.decrease_up_light_brightness
IncreaseDownLightBrightness
→ bond.increase_down_light_brightness
DecreaseDownLightBrightness
→ bond.decrease_down_light_brightness
Although I think that will only work for lights that know their current brightness level.
bdraco
August 22, 2021, 4:14am
23
I’m pretty sure you need StartIncreasingBrightness
, StartDecreasingBrightness
, and Stop
home-assistant:dev
← bdraco:bond_brightness
opened 04:01AM - 22 Aug 21 UTC
## Proposed change
<!--
Describe the big picture of your changes here to com… municate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
- Some lights do not support setting a brightness value and can
only start and stop increasing or decreasing brightness
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
I can only try the failure path since I don’t have a light that supports the above actions.
I also uploaded the changes to github if you want to try it as a custom component:
From the command line:
mkdir -p /config/custom_components
cd /config/custom_components
git clone https://github.com/bdraco/bond
Restart Home Assistant
1 Like
Bdraco,
I’ve been seeing your handle over in the home assistant forum. Thank you for all of your good work. I saw your post last night, and finally got around to testing. It wasn’t much of a test, as everything just worked as expected. In celebration, I created a script to turn on and set a brightness based on a 5 sec delay.
sequence:
- type: turn_on
device_id: 5c30a614b48dadc0c02a9eaa9330a483
entity_id: light.tornado
domain: light
- service: bond.start_increasing_brightness
target:
entity_id: light.tornado
- delay:
hours: 0
minutes: 0
seconds: 5
milliseconds: 0
- service: bond.stop
target:
entity_id: light.tornado
mode: single
alias: tornado light on and bright 5 seconds
Thank you!
4 Likes
bdraco
August 25, 2021, 8:29pm
25
Once Home Assistant 2021.9 is released, you should be able to remove the custom version as the change merged into core. Also, the change will be in today’s Home Assistant beta as well.
2 Likes
bdraco
January 22, 2022, 10:07pm
26
@Jpfamily Quick heads up that these services are getting replaced with the new button platform so the you’ll have to update your automations before the old methods go away.
home-assistant:dev
← bdraco:bond_button_platform
opened 10:03PM - 22 Jan 22 UTC
<!--
You are amazing! Thanks for contributing to our project!
Please, DO N… OT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did this.
This piece of text is published with the release notes, so it helps if you
write it towards our users, not us.
Note: Remove this section if this PR is NOT a breaking change.
-->
The custom `start_increasing_brightness`, `start_decreasing_brightness` and `stop` services are now deprecated and will be removed in a future release. Use the new button platform instead.
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Add button platform to bond.
The following buttons are now available for devices that do not support tracking state. For example, if the device can set brightness, increase and decrease brightness buttons will not be created.
- Stop Actions
- Toggle Power
- Toggle Light
- Increase Brightness
- Decrease Brightness
- Toggle Up Light
- Toggle Down Light
- Start Up Light Dimmer
- Start Down Light Dimmer
- Start Increasing Brightness
- Start Decreasing Brightness
- Increase Up Light Brightness
- Decrease Up Light Brightness
- Increase Down Light Brightness
- Decrease Down Light Brightness
- Cycle Up Light Brightness
- Cycle Down Light Brightness
- Cycle Brightness
- Increase Speed
- Decrease Speed
- Toggle Direction
- Increase Temperature
- Decrease Temperature
- Increase Flame
- Decrease Flame
- Toggle Open
## Type of change
<!--
What type of change does your PR introduce to Home Assistant?
NOTE: Please, check only 1! box!
If your PR requires multiple boxes to be checked, you'll most likely need to
split it into multiple PRs. This makes things easier and faster to code review.
-->
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [x] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/21300
## Checklist
<!--
Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look
for before merging your code.
-->
- [x] The code change is tested and works locally.
- [ ] Local tests pass. **Your PR cannot be merged unless tests pass**
- [ ] There is no commented out code in this PR.
- [ ] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (`black --fast homeassistant tests`)
- [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running: `python3 -m script.hassfest`.
- [ ] New or updated dependencies have been added to `requirements_all.txt`.
Updated by running `python3 -m script.gen_requirements_all`.
- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to `.coveragerc`.
The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
<!--
The Integration Quality Scale scores an integration on the code quality
and user experience. Each level of the quality scale consists of a list
of requirements. We highly recommend getting your integration scored!
-->
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
<!--
This project is very active and we have a high turnover of pull requests.
Unfortunately, the number of incoming pull requests is higher than what our
reviewers can review and merge so there is a long backlog of pull requests
waiting for review. You can help here!
By reviewing another pull request, you will help raise the code quality of
that pull request and the final review will be faster. This way the general
pace of pull request reviews will go up and your wait time will go down.
When picking a pull request to review, try to choose one that hasn't yet
been reviewed.
Thanks for helping out!
-->
To help with the load of incoming pull requests:
- [ ] I have reviewed two other [open pull requests][prs] in this repository.
[prs]: https://github.com/home-assistant/core/pulls?q=is%3Aopen+is%3Apr+-author%3A%40me+-draft%3Atrue+-label%3Awaiting-for-upstream+sort%3Acreated-desc+review%3Anone+-status%3Afailure
<!--
Thank you for contributing <3
Below, some useful links you could explore:
-->
[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
[manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
[quality-scale]: https://developers.home-assistant.io/docs/en/next/integration_quality_scale_index.html
[docs-repository]: https://github.com/home-assistant/home-assistant.io
I saw your message… And was a little confused on how/what to expect. I hadn’t fully implemented the service call into automations, as I kept having to deal with the 700 series zwave bug that would leave devices in unresponsive states.
I literally just checked the default dashboard… And was mesmerized by the new button function available. It seems that out of habit, I would fallback to the bond app to do dimming because it was an old habit.
Having the button press available in the default dashboard just made my day so much easier. It is literally becoming the one universal location for all my device needs.
Thanks for the warning. I appreciate the heads up. Another reason I love the HA community.
1 Like